0001518: Old Book can be taken again after we found the Golden Compass

ID	Category	Date Submitted	Last Update

0001518	Bug Report	2019-02-18 15:49	2019-05-03 06:46

Reporter	Casiope
Severity	trivial	Reproducibility	always
Status	closed	Resolution	open

Summary	0001518: Old Book can be taken again after we found the Golden Compass
Description	See attachment. A very small bug easy to fix. We are able to return the Old Book item to the library after we found the Golden Compass. Then the Old Book reappears in the bookshelf and we can take it again. It's a bug because this book is the only one to have this behaviour; all the other books (French Love, Cheeses, The Breeder Guide) diseappear definetely when they are returned to Jane. Every item without use should be removed from in-game to avoid confusion. Steps to reproduce: 1. Progress in Aqua's storyline until Mc finds the Golden Compass. 2. Go to the library. 3. Click on Jane. 4. Click on "Talk to the librarian." 5. Choose the dialogue's choice "Return library books". 6. Click on the bookshelf. Issues: • The Old Book is in the bookshelf. • We can click on it and take it again. • MC says "This book looks like it would be useful decoding something." • We have the popup "You have a new item in your backpack! Book:" • The Old Book is in the inventory. • But this item is now useless because we don't need it anymore! Solution: • The Old Book shouldn't reappear in the bookshelf after we returned it.

Platform/OS	Windows
Version	0.17.5

Casiope 2019-02-18 15:49 updater	Old book.jpg (311,541 bytes)

Casiope 2019-02-18 16:05 updater ~0001960	Correction in defines\images\LiveComposites, line 120: (836,108), ConditionSwitch("not player.has_item(\"old_book\")", "buttons/book_05.png", "True", Null()), --> (836,108), ConditionSwitch("not M_aqua.finished_state(S_aqua_treasure_unlock) and not player.has_item(\"old_book\")", "buttons/book_05.png", "True", Null()),

Casiope 2019-02-18 16:25 updater ~0001961	And you could do also some cleaning in core\core, line 94: if player.has_item("old_book") and M_aqua.is_state((S_aqua_trade, S_aqua_fishing, S_aqua_chase, S_aqua_squid_gaurd, S_aqua_maze, S_aqua_lair, S_aqua_found, S_aqua_mating_proposal, S_aqua_valor_test, S_aqua_mate, S_aqua_seasucc_intro, S_aqua_seasucc_mushroom, S_aqua_end)): --> if player.has_item("old_book") and M_aqua.finished_state(S_aqua_treasure_unlock):

mil578 2019-05-03 06:46 updater ~0002229	Forwarded to a future update or already fixed.

Date Modified	Username	Field	Change
2019-02-18 15:49	Casiope	New Issue
2019-02-18 15:49	Casiope	File Added: Old book.jpg
2019-02-18 16:05	Casiope	Note Added: 0001960
2019-02-18 16:25	Casiope	Note Added: 0001961
2019-05-03 06:46	mil578	Note Added: 0002229
2019-05-03 06:46	mil578	Status	new => closed